Comments on: deUncategorize 1.1a: Firefox Bugfix

By: Daniel

Daniel — Wed, 06 Dec 2006 10:15:25 +0000

Hi Gideon, thanks for your feedback! You are right, the plugin didn't work with the IE. I've fixed it (using a different approach than you suggested) and mailed the fixed version to you. ~~I'll release it as soon as I get positive feedback from you.~~ It's released: deUncategorize 1.2: Internet Explorer Fix. The operator !== means "not identical". I've used it because I expect a String in the given situation. See the PHP: Comparison Operators - Manual for a detailed explanation:

$a !== $b -- Not identical -- TRUE if $a is not equal to $b, or they are not of the same type. (introduced in PHP 4)

And for your last point: you can leave the == true out of course. At some point though I wanted to make it clear. Because of the code changes I've made it is no longer necessary and I've saved eight chars bandwidth ;-)

By: Gideon Melle

Gideon Melle — Wed, 06 Dec 2006 07:19:56 +0000

Hi, I have downloaded your plugin. It works like a charm with Firefox but unfortunate not with IE5+. I like at the code en indeed the setAttribute stuff is oknown to not work with IE5+. Probably you are not a IE-user, but it would be nice to get it to work also with this browser. I searched a bit and stumbled upon this function:

function eventAdder(objAttrib,handler,addFunction){
	     
	   if ((!document.all)&&(document.getElementById)){
	       objAttrib.setAttribute(handler,addFunction);
	   }    
	   //workaround for IE 5.x
	   if ((document.all)&&(document.getElementById)){
	       objAttrib[handler]=new Function(addFunction);
	   }
	}

Could you use it? Then i saw that you use an operator !== in this line: if ($uncategorizedCategoryInternalName !== '') Is that on purpose or a typo? I never came across this! Also the phrase: if (document.getElementById(\'' + curr.id + '\').checked == true) seems to me the same as: if (document.getElementById(\'' + curr.id + '\').checked) Greetings, Gideon van Melle [I've added <code> tags to your comment to make it better readable. -- Daniel]

By: Daniel

Daniel — Mon, 27 Nov 2006 16:35:04 +0000

Just click on one of the two links to http://cinnamonthoughts.org/wordpress/deuncategorize/ or use the link in the pages menu.

By: guan

guan — Mon, 27 Nov 2006 16:31:39 +0000

How the hell am i supposed to download the plugin ?